[課題管理]レポートのCSV出力処理をリファクタリングしました #2198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSVインポート処理に合わせて実装を変更
キャメルケースになっていたのでテストがこけていた
テストが通るようにColumnDefinitionFactory の第二引数はcheckerに変更
親クラスでMockery::close()が呼ばれるので不要
gakigaki
added
ignore for release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
CSV入力処理に合わせて、リファクタリングしました。
レビュー完了希望日
関連Pull requests/Issues
参考
DB変更の有無
無し
チェックリスト